add optional tor_cmd param for Tor not on PATH#9
Open
fiveham wants to merge 1 commit intoerdiaker:masterfrom
Open
add optional tor_cmd param for Tor not on PATH#9fiveham wants to merge 1 commit intoerdiaker:masterfrom
fiveham wants to merge 1 commit intoerdiaker:masterfrom
Conversation
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to use torrequest, it crashed:
When torrequest calls
stem.process.launch_tor_with_config, it does not specify ator_cmdparam; so, the default value'tor'is used. I have Tor, but it's not on the PATH and never will be (because an anonymous person on the internet said that would be a security risk).By adding this optional param for TorRequest, other users in my situation should be able to use the class much more easily by specifying
tor_cmd='path/to/tor/folder/TorBrowser/Tor/tor.exe'for example.